Fixes #269 dev container broken on M1/ARM#270
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #270 +/- ##
=======================================
Coverage 89.28% 89.28%
=======================================
Files 52 52
Lines 2155 2155
=======================================
Hits 1924 1924
Misses 231 231 Continue to review full report at Codecov.
|
wcs1only
approved these changes
Sep 8, 2021
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Python-sdk dev container breaks during docker build for 2 reasons:
The fix simply changes the base image to a newer one that is bullseye based, and second makes the architecture parameter dynamic based on your machine.
Issue reference
Please reference the issue this PR will close: #269
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: